Project

General

Profile

Logged in as brainvisa
Watch Actions

Defect #17519

closed

QT_API is unconditionally set to pyqt

Added by Riviere, Denis over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
brainvisa-cmake
Start date:
25/10/2017
Due date:
% Done:

100%

Estimated time:
Resolution:

Description

We now also support Qt5/PyQt5, so this env variable is not always correct. Its value should depend on the config of the build tree, and still be available in the installed version.

Maybe bv_env should be able to read an additional config file with some install-specific variables.

Or build bv_env with the correct value builtin, but this is not easy since bv_env is built before configuring other projects, at a time we don't know yet if we will be using Qt4 or Qt5. Or maybe use the DESIRED_QT_VERSION variable from cmake ?

Actions #1

Updated by Souedet, Nicolas over 6 years ago

I think it should be possible to add a cmake variable given through bv_maker (and its configuration file) that can be passed both to the brainvisa-cmake project configuration and also to other projects. This allow to build bv_env with the correct environment variable builtin. The easiest way is to use the DESIRED_QT_VERSION variable from cmake.

Actions #2

Updated by Riviere, Denis over 6 years ago

  • Status changed from New to In progress
  • Assignee set to Riviere, Denis
Actions #3

Updated by Riviere, Denis over 6 years ago

  • Status changed from In progress to Closed
  • % Done changed from 0 to 100

Appliqué par commit r79611.

Watch Actions

Also available in: Atom PDF